Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(forms): align subtext wrapper validate icon #1594

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

fix(forms): align subtext wrapper validate icon #1594

wants to merge 4 commits into from

Conversation

dtsanevmw
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • If applicable, have a visual design approval

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Validate icon inside subtext-wrapper is not aligned.

Issue Number: N/A

What is the new behavior?

Validate icon inside subtext-wrapper is aligned.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@dtsanevmw dtsanevmw requested a review from a team October 15, 2024 07:31
@dtsanevmw dtsanevmw self-assigned this Oct 15, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 15, 2024 •
edited
Loading

👋 @dtsanevmw,

  • 🙏 The Clarity team thanks you for opening a pull request
  • 🎉 The build for this PR has succeeded
  • 🔍 The PR is now ready for review
  • 🍿 In the meantime, view a preview of this PR
  • 🖐 You can always follow up here. If you're a VMware employee, you can also reach us on our internal Clarity Support space

Thank you,

🤖 Clarity Release Bot

@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
@dtsanevmw dtsanevmw force-pushed the dtsanevmw/align_helper_validate_icon branch 2 times, most recently from 3379fb6 to 088f830 Compare October 15, 2024 10:38
@github-actions GitHub Actions

This comment was marked as resolved.

Sign in to view
@github-actions GitHub Actions
Copy link
Contributor

This PR introduces visual changes: dca43a2
If these changes are intended and correct, please cherry-pick the above commit to this PR.

git checkout dtsanevmw/align_helper_validate_icon
git fetch https://github.com/vmware-clarity/ng-clarity.git dca43a251e4bb244b5ab93ab2642a5a046a4c04f
git cherry-pick dca43a251e4bb244b5ab93ab2642a5a046a4c04f
git push

@dtsanevmw dtsanevmw force-pushed the dtsanevmw/align_helper_validate_icon branch from 0454510 to 2265218 Compare October 15, 2024 14:38
dtsanevmw
dtsanevmw commented Oct 15, 2024
View reviewed changes
projects/angular/src/forms/styles/_radio.clarity.scss
@@ -85,7 +85,6 @@
}

.clr-form-compact .clr-radio-wrapper {
@include forms-mixins.form-flatten-compact-adjustments();
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Creating inconsistency between other form controls and radio / checkbox because of specificity being higher here and overriding what is in _containers.clarity.scss

dtsanevmw
dtsanevmw commented Oct 15, 2024
View reviewed changes
projects/angular/src/forms/styles/_checkbox.clarity.scss
@@ -128,7 +128,6 @@
}

.clr-form-compact .clr-checkbox-wrapper {
@include forms-mixins.form-flatten-compact-adjustments();
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Creating inconsistency between other form controls and radio / checkbox because of specificity being higher here and overriding what is in _containers.clarity.scss

@dtsanevmw dtsanevmw marked this pull request as draft October 15, 2024 14:43
@dtsanevmw dtsanevmw removed the request for review from a team October 15, 2024 14:43
@github-actions GitHub Actions
Copy link
Contributor

This PR introduces visual changes: 356c6dd
If these changes are intended and correct, please cherry-pick the above commit to this PR.

git checkout dtsanevmw/align_helper_validate_icon
git fetch https://github.com/vmware-clarity/ng-clarity.git 356c6ddac840d34ce9171e79e60e4c37d536a731
git cherry-pick 356c6ddac840d34ce9171e79e60e4c37d536a731
git push

@dtsanevmw dtsanevmw force-pushed the dtsanevmw/align_helper_validate_icon branch from 2265218 to 1c7ea4a Compare October 16, 2024 10:39
@github-actions GitHub Actions
Copy link
Contributor

This PR introduces visual changes: 5288d78
If these changes are intended and correct, please cherry-pick the above commit to this PR.

git checkout dtsanevmw/align_helper_validate_icon
git fetch https://github.com/vmware-clarity/ng-clarity.git 5288d781e18f238097a0e5f85462ec69dda87746
git cherry-pick 5288d781e18f238097a0e5f85462ec69dda87746
git push

@dtsanevmw dtsanevmw force-pushed the dtsanevmw/align_helper_validate_icon branch from 27b779c to 0e5fc19 Compare October 16, 2024 12:09
@github-actions GitHub Actions
Copy link
Contributor

This PR introduces visual changes: aa59f61
If these changes are intended and correct, please cherry-pick the above commit to this PR.

git checkout dtsanevmw/align_helper_validate_icon
git fetch https://github.com/vmware-clarity/ng-clarity.git aa59f6119a58e3700b37154058ad4b698102ea84
git cherry-pick aa59f6119a58e3700b37154058ad4b698102ea84
git push

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@dtsanevmw dtsanevmw

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dtsanevmw @web-flow