Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(alerts): update dark theme colors #1596

Merged
merged 2 commits into from
Oct 17, 2024

Conversation

valentin-mladenov
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • If applicable, have a visual design approval

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Alert --clr-alert-warning-font-color point to --cds-global-color-black.

Issue Number: CDE-2339

What is the new behavior?

Dark theme overrides
--cds-alias-status-warning-tint point to --cds-global-color-ochre-900
--cds-alias-status-danger-tint point to --cds-global-color-red-900

Alert --clr-alert-warning-font-color point to --cds-alias-typography-color-500.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Copy link
Contributor

github-actions bot commented Oct 15, 2024

👋 @valentin-mladenov,

  • 🙏 The Clarity team thanks you for opening a pull request
  • 🎉 The build for this PR has succeeded
  • 🔍 The PR is now ready for review
  • 🍿 In the meantime, view a preview of this PR
  • 🖐 You can always follow up here. If you're a VMware employee, you can also reach us on our internal Clarity Support space

Thank you,

🤖 Clarity Release Bot

Copy link
Contributor

This PR introduces visual changes: 48cbe60
If these changes are intended and correct, please cherry-pick the above commit to this PR.

git checkout dark-theme-alerts_cde-2339
git fetch https://github.com/vmware-clarity/ng-clarity.git 48cbe6066977cec237f01cfd4293902605f102dc
git cherry-pick 48cbe6066977cec237f01cfd4293902605f102dc
git push

@valentin-mladenov valentin-mladenov marked this pull request as ready for review October 17, 2024 07:48
@valentin-mladenov
Copy link
Contributor Author

Folow up of vmware-clarity/core#335

@valentin-mladenov valentin-mladenov merged commit 6a57512 into main Oct 17, 2024
8 checks passed
@valentin-mladenov valentin-mladenov deleted the dark-theme-alerts_cde-2339 branch October 17, 2024 09:34
Copy link
Contributor

github-actions bot commented Nov 1, 2024

Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed PRs after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary.

@github-actions github-actions bot locked and limited conversation to collaborators Nov 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants