-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(datagrid): filter improvements #1597
base: main
Are you sure you want to change the base?
Conversation
👋 @mivaylo,
Thank you, 🤖 Clarity Release Bot |
This PR introduces visual changes: 31104b2
|
projects/angular/src/data/datagrid/built-in/filters/datagrid-numeric-filter.ts
Outdated
Show resolved
Hide resolved
This PR introduces visual changes: b310bd6
|
This PR introduces visual changes: 9d0e10c
|
This PR introduces visual changes: efe0840
|
This PR introduces visual changes: f478579
|
projects/angular/src/data/datagrid/built-in/filters/datagrid-string-filter.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The screenshots don't seem right to me. The signpost trigger probably shouldn't be on its own line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why we have a signpost in the signpost?
…tring-filter.ts Co-authored-by: Kevin Buhmann <kbuhmann@vmware.com>
This PR introduces visual changes: 71de679
|
This PR introduces visual changes: bfc553b
|
Waiting for feedback from a11y point of view on that |
This PR introduces visual changes: ba67704
|
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: CDE-2281
What is the new behavior?
Does this PR introduce a breaking change?
Other information