Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(datagrid): filter improvements #1597

Open
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

mivaylo
Copy link
Contributor

@mivaylo mivaylo commented Oct 16, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • If applicable, have a visual design approval

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: CDE-2281

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Copy link
Contributor

github-actions bot commented Oct 16, 2024

👋 @mivaylo,

  • 🙏 The Clarity team thanks you for opening a pull request
  • 🎉 The build for this PR has succeeded
  • 🔍 The PR is now ready for review
  • 🍿 In the meantime, view a preview of this PR
  • 🖐 You can always follow up here. If you're a VMware employee, you can also reach us on our internal Clarity Support space

Thank you,

🤖 Clarity Release Bot

Copy link
Contributor

This PR introduces visual changes: 31104b2
If these changes are intended and correct, please cherry-pick the above commit to this PR.

git checkout cde-2281-datagrid-filter-a11y-improvements
git fetch https://github.com/vmware-clarity/ng-clarity.git 31104b24f304635cee6c27f894cbebaeb8539870
git cherry-pick 31104b24f304635cee6c27f894cbebaeb8539870
git push

@mivaylo mivaylo marked this pull request as draft October 17, 2024 13:29
Copy link
Contributor

This PR introduces visual changes: b310bd6
If these changes are intended and correct, please cherry-pick the above commit to this PR.

git checkout cde-2281-datagrid-filter-a11y-improvements
git fetch https://github.com/vmware-clarity/ng-clarity.git b310bd6bd1d8dec18043ad9d5e9d542b07a76cfc
git cherry-pick b310bd6bd1d8dec18043ad9d5e9d542b07a76cfc
git push

Copy link
Contributor

This PR introduces visual changes: 9d0e10c
If these changes are intended and correct, please cherry-pick the above commit to this PR.

git checkout cde-2281-datagrid-filter-a11y-improvements
git fetch https://github.com/vmware-clarity/ng-clarity.git 9d0e10cc64f446f549705b91a73d1c3222e2bee9
git cherry-pick 9d0e10cc64f446f549705b91a73d1c3222e2bee9
git push

Copy link
Contributor

This PR introduces visual changes: efe0840
If these changes are intended and correct, please cherry-pick the above commit to this PR.

git checkout cde-2281-datagrid-filter-a11y-improvements
git fetch https://github.com/vmware-clarity/ng-clarity.git efe08408b2a18f9ef7473c9f7644f233b5865554
git cherry-pick efe08408b2a18f9ef7473c9f7644f233b5865554
git push

Copy link
Contributor

This PR introduces visual changes: f478579
If these changes are intended and correct, please cherry-pick the above commit to this PR.

git checkout cde-2281-datagrid-filter-a11y-improvements
git fetch https://github.com/vmware-clarity/ng-clarity.git f478579d156249b580104e00d40a72848c65556c
git cherry-pick f478579d156249b580104e00d40a72848c65556c
git push

@mivaylo mivaylo marked this pull request as ready for review October 24, 2024 07:32
Copy link
Member

@kevinbuhmann kevinbuhmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The screenshots don't seem right to me. The signpost trigger probably shouldn't be on its own line.

Copy link
Contributor

@dtsanevmw dtsanevmw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why we have a signpost in the signpost?

…tring-filter.ts

Co-authored-by: Kevin Buhmann <kbuhmann@vmware.com>
Copy link
Contributor

github-actions bot commented Nov 1, 2024

This PR introduces visual changes: 71de679
If these changes are intended and correct, please cherry-pick the above commit to this PR.

git checkout cde-2281-datagrid-filter-a11y-improvements
git fetch https://github.com/vmware-clarity/ng-clarity.git 71de679de68b1136c76d783c5746077ff4f52c37
git cherry-pick 71de679de68b1136c76d783c5746077ff4f52c37
git push

Copy link
Contributor

github-actions bot commented Nov 1, 2024

This PR introduces visual changes: bfc553b
If these changes are intended and correct, please cherry-pick the above commit to this PR.

git checkout cde-2281-datagrid-filter-a11y-improvements
git fetch https://github.com/vmware-clarity/ng-clarity.git bfc553b9740888682c5fe8b05b0775b77f626bf6
git cherry-pick bfc553b9740888682c5fe8b05b0775b77f626bf6
git push

@mivaylo
Copy link
Contributor Author

mivaylo commented Nov 4, 2024

Why we have a signpost in the signpost?

Waiting for feedback from a11y point of view on that

Copy link
Contributor

github-actions bot commented Nov 4, 2024

This PR introduces visual changes: ba67704
If these changes are intended and correct, please cherry-pick the above commit to this PR.

git checkout cde-2281-datagrid-filter-a11y-improvements
git fetch https://github.com/vmware-clarity/ng-clarity.git ba677049a66cfbb1f0e03586e5c03a6af3154727
git cherry-pick ba677049a66cfbb1f0e03586e5c03a6af3154727
git push

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants