fix(datagrid): add unique aria label #1599
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 @mivaylo,
Thank you, 🤖 Clarity Release Bot |
dtsanevmw
requested changes
Oct 24, 2024
| @@ -25,7 +25,7 @@ import { DatagridNumericFilterImpl } from './datagrid-numeric-filter-impl'; | |||
| <clr-dg-filter [clrDgFilter]="registered" [(clrDgFilterOpen)]="open"> | |||
| <div class="datagrid-numeric-filter-form"> | |||
| <div class="clr-form-control"> | |||
| <label class="clr-control-label">{{ fromLabelValue }}</label> | |||
| <label class="clr-control-label" [attr.aria-label]="'From'">{{ fromLabelValue }}</label> | |||
There was a problem hiding this comment.
Why does a label that has visible text need an aria label?
There was a problem hiding this comment.
This hard-coded label isn't any more unique than the visible text, and only one filter can be open at a time anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information