Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify names and build scripts for libs and for wlr-* #80

Merged
merged 13 commits into from
Mar 10, 2023
Merged

Conversation

assambar
Copy link
Contributor

  • all external libs now use libs/${LIBNAME{/v${VERSION} folder. tag is already set in wlr-env-repo.sh
  • all internal libs only use libs/${LIBNAME}
  • add separate GH reusable release flow and Makefile macros for external and internal libs targets
  • GH reusable workflows are simplified and package *.tar.gz, so build params are reduced
  • added README.md for libs/ and a basic one for each lib
  • renamed all wasmlabs references to wlr in variables, text and script names
  • split the logic in wlr-env.sh into several functions which get called one by one - to make it more readable
  • exposed a few more relevant WLR_* variables when running build in a container (with make)

Makefile Outdated Show resolved Hide resolved
Makefile.helpers Outdated Show resolved Hide resolved
Makefile.helpers Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
libs/README.md Outdated Show resolved Hide resolved
libs/README.md Outdated Show resolved Hide resolved
libs/README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@ereslibre ereslibre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides @gzurl comments, LGTM. Thanks @assambar! Thanks for the wlr-test scripts, now we are a step closer to piping them to our GH actions!

libs/wasmedge_sock/wlr-build.sh Outdated Show resolved Hide resolved
libs/wasmedge_sock/wlr-build.sh Outdated Show resolved Hide resolved
php/php-8.2.0-slim/wlr-test.sh Outdated Show resolved Hide resolved
@gzurl
Copy link
Contributor

gzurl commented Mar 10, 2023

Great job! Ship it!

@assambar assambar merged commit c46e363 into main Mar 10, 2023
@assambar assambar deleted the refactor-scripts branch March 10, 2023 13:59
@assambar assambar mentioned this pull request Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants