Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor improvements for kn-pcli-template function #871

Closed
kremerpatrick opened this issue Apr 26, 2022 · 0 comments · Fixed by #872
Closed

Minor improvements for kn-pcli-template function #871

kremerpatrick opened this issue Apr 26, 2022 · 0 comments · Fixed by #872
Assignees
@kremerpatrick
Labels
documentation Improvements or additions to documentation
Milestone
v0.7.3

Comments

@kremerpatrick
Copy link

Fix the following in the kn-pcli-template

  • Set default certificate action to Fail
  • Bottom line of function.yaml should be updated with REPLACE-FN-NAME
  • Update readme to show function.yaml as a file that needs to be searched for secret references
@kremerpatrick kremerpatrick added the enhancement New feature or request label Apr 26, 2022
@kremerpatrick kremerpatrick self-assigned this Apr 26, 2022
kremerpatrick pushed a commit to kremerpatrick/vcenter-event-broker-appliance that referenced this issue Apr 26, 2022
docs: Update kn-pcli-template
4f7dc04 
Closes vmware-samples#871

Signed-off-by: Patrick Kremer <pkremer@vmware.com>
@kremerpatrick kremerpatrick mentioned this issue Apr 26, 2022
Merged
15 tasks
@kremerpatrick kremerpatrick added documentation Improvements or additions to documentation and removed enhancement New feature or request labels Apr 26, 2022
@embano1 embano1 added this to the v0.7.3 milestone Apr 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kremerpatrick kremerpatrick

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
v0.7.3
Development

Successfully merging a pull request may close this issue.

Update kn-pcli-template kremerpatrick/vcenter-event-broker-appliance
2 participants
@embano1 @kremerpatrick