Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use 1.0 tag for py-vm-attr image #438

Merged
merged 1 commit into from
Jun 3, 2021

Conversation

embano1
Copy link
Collaborator

@embano1 embano1 commented Jun 3, 2021

Summary

I the PR review of this function I gave the wrong advice to use latest tag. This fixes it. Image is pushed correctly to the registry.

Closes: #437
Signed-off-by: Michael Gasch mgasch@vmware.com

Pull Request Checklist

🚨 Please review the guidelines for contributing to this repository.

  • Please ensure that you are making a pull request against the Development branch
  • Please use the WIP keyword in the title of your PR if you are not ready for review
  • Please ensure that you have opened a Github Issue if you are resolving/fixing a problem
  • Please ensure that you have signed all commits and that you have squashed all relevant commits related to your change
  • Please make sure that you have tested your change locally by successfully building and deploying the VMware Event Broker Appliance and/or building and deploying VMware Event Router
  • Please include any relevant screenshots and/or output as part of your testing
  • Please include any documentation updates that is applicable for your changes

Change Type

What types of changes does your code introduce to the VMware Event Broker Appliance?

Put an x in all boxes that apply

Please check the type of change your PR introduces:

  • Bugfix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation changes
  • Other (please describe):

Resolved Issues

List of Issues closed or resolved by this PR. Add multiple Closes keyword followed by the issue number (e.g. Closes #ISSUE-NUMBER)

Closes #ISSUE-NUMBER

Testing Verification

  • Short summary of testing (e.g. successfully built and deployed VMware Event Broker Appliance)
  • Please include any relevant screenshots and/or output as part of the testing

Additional Information

  • Any other details you wish to include or mention

If you have any questions/comments, feel free to reach out to team on Slack #vcenter-event-broker-appliance

Thank you from the VEBA Team! 🥳

Closes: vmware-samples#437
Signed-off-by: Michael Gasch <mgasch@vmware.com>
@embano1 embano1 changed the title Use 1.0 tag for image Use 1.0 tag for py-vm-attr image Jun 3, 2021
@embano1 embano1 requested a review from lamw June 3, 2021 10:45
Copy link
Contributor

@lamw lamw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@embano1 embano1 merged commit 2e88e3f into vmware-samples:development Jun 3, 2021
@embano1 embano1 deleted the issue-437 branch June 3, 2021 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kn-py-vm image should use v1.0 tag
2 participants