Skip to content

Commit

Permalink
hack: make docker_config overwritable
Browse files Browse the repository at this point in the history
although the whole flow of installing / updating etc with _just_
`hack/setup.sh` works great as is, if someone has already configured a
registry _outside_ `hack/setup.sh`, we end up not being able to install
cartographer with something like `hack/setup.sh cartographer`. by making
`DOCKER_CONFIG` configurable, we can have that set and then allow
installation of cartographer making use of `hack/setup.sh`.

Signed-off-by: Ciro S. Costa <ciroscosta@vmware.com>
  • Loading branch information
Ciro S. Costa committed Nov 11, 2021
1 parent d6e4c01 commit 26f0282
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion hack/setup.sh
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ readonly REGISTRY=${REGISTRY:-"${HOST_ADDR}:${REGISTRY_PORT}"}
readonly KIND_IMAGE=${KIND_IMAGE:-kindest/node:v1.21.1}
readonly RELEASE_VERSION=${RELEASE_VERSION:-""}
# shellcheck disable=SC2034 # This _should_ be marked as an extern but I clearly don't understand how it operates in github actions
readonly DOCKER_CONFIG="/tmp/cartographer-docker"
readonly DOCKER_CONFIG=${DOCKER_CONFIG:-"/tmp/cartographer-docker"}

readonly REGISTRY_CONTAINER_NAME=cartographer-registry
readonly KUBERNETES_CONTAINER_NAME=cartographer-control-plane
Expand Down

0 comments on commit 26f0282

Please sign in to comment.