flip conditional on RetrieveOutputError for clarity

vmware-tanzu · Mar 29, 2023 · 8b33b8c · 8b33b8c
1 parent 515f38b
commit 8b33b8c
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/pkg/conditions/workload_conditions.go b/pkg/conditions/workload_conditions.go
@@ -91,10 +91,10 @@ func AddConditionForResourceSubmittedWorkload(conditionManager *ConditionManager
 	case cerrors.NoHealthyImmutableObjectsError:
 		(*conditionManager).AddPositive(NoHealthyImmutableObjectsCondition(isOwner, typedErr))
 	case cerrors.RetrieveOutputError:
-		if typedErr.PassThroughInput == "" {
-			(*conditionManager).AddPositive(MissingValueAtPathCondition(isOwner, typedErr.StampedObject, typedErr.JsonPathExpression(), typedErr.GetQualifiedResource()))
-		} else {
+		if typedErr.StampedObject == nil {
 			(*conditionManager).AddPositive(MissingPassThroughInputCondition(typedErr.PassThroughInput, typedErr.GetQualifiedResource()))
+		} else {
+			(*conditionManager).AddPositive(MissingValueAtPathCondition(isOwner, typedErr.StampedObject, typedErr.JsonPathExpression(), typedErr.GetQualifiedResource()))
 		}
 	case cerrors.ResolveTemplateOptionError:
 		(*conditionManager).AddPositive(ResolveTemplateOptionsErrorCondition(isOwner, typedErr))