If jsonpath returns empty or nil, we should error (#267)

* If jsonpath returns empty or nil, we should error Co-authored-by: Sam Coward <scoward@vmware.com>
vmware-tanzu · Oct 27, 2021 · a5a259a · a5a259a
1 parent 53df43d
commit a5a259a
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/pkg/eval/jsonpath.go b/pkg/eval/jsonpath.go
@@ -52,6 +52,10 @@ func (e Evaluator) EvaluateJsonPath(path string, obj interface{}) (interface{},
 		return "", fmt.Errorf("too many results for the query: %s", path)
 	}
 
+	if len(interfaceList) == 0 {
+		return "", fmt.Errorf("jsonpath returned empty list: %s", path)
+	}
+
 	return interfaceList[0], nil
 }
 

diff --git a/pkg/eval/jsonpath_test.go b/pkg/eval/jsonpath_test.go
@@ -100,15 +100,11 @@ var _ = Describe("JsonPath", func() {
 
 		Context("when evaluate returns a list of no items", func() {
 			BeforeEach(func() {
-				evaluate.Returns([]interface{}{"some error"}, nil)
+				evaluate.Returns([]interface{}{}, nil)
 				result, err = evaluator.EvaluateJsonPath(path, obj)
 			})
 
-			ItDoesNotReturnAnError()
-
-			It("returns that single item", func() {
-				Expect(result).To(Equal("some error"))
-			})
+			ItReturnsAHelpfulError("jsonpath returned empty list")
 		})
 
 		Context("when evaluate returns a list with a single item", func() {