Skip to content

Commit

Permalink
examples: use dockerconfigjson type for kpack
Browse files Browse the repository at this point in the history
it turns out that the use of `basic-auth` doesn't play nice with
imagePullSecrets - the fetching of registry credentials from
`basic-auth`-typed secrets is somethign that just tekton/kpack
controllers themselves deal with, but not kubelet

Signed-off-by: Ciro S. Costa <ciroscosta@vmware.com>
  • Loading branch information
Ciro S. Costa committed Sep 22, 2021
1 parent 4c18207 commit baf6c2c
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions examples/source-to-knative-service/00-cluster/secret.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -13,14 +13,14 @@
# limitations under the License.

#@ load("@ytt:data", "data")
#@ load("@ytt:json", "json")

---
apiVersion: v1
kind: Secret
metadata:
name: registry-credentials
annotations:
kpack.io/docker: #@ data.values.registry.server
type: kubernetes.io/basic-auth
type: kubernetes.io/dockerconfigjson
stringData:
username: #@ data.values.registry.username
password: #@ data.values.registry.password
#@ registry_creds = {"username": data.values.registry.username, "password": data.values.registry.password}
.dockerconfigjson: #@ json.encode({"auths": {data.values.registry.server: registry_creds}})

0 comments on commit baf6c2c

Please sign in to comment.