Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cartotest supplychains #1265

Merged
merged 50 commits into from
Jun 21, 2023
Merged

Cartotest supplychains #1265

merged 50 commits into from
Jun 21, 2023

Conversation

waciumawanjohi
Copy link
Contributor

@waciumawanjohi waciumawanjohi commented Jun 9, 2023 •
edited
Loading

Changes proposed by this PR

Large rewrite of Cartotest

  • Allow cartotest to accept supplychains alongside templates and workloads.
  • Use abstraction to clarify the interface
  • Add comparison option functions (for example, coercing numbers in expected and actual to be the same type)

Release Note

Cartotest Improvement: Users may specify an actual supply chain or set of supply chain set when testing that the proper object is stamped.

!Breaking changes to CartoTest! CartoTest accepts interfaces rather than multiple concrete instances providing the same functionality. Field names have been shortened (e.g. TemplateTestCase --> Test). See changes to tests/templates/template_test.go for examples of rewriting existing tests to the new API.

Cherry-pick branches

All minor branches. Has not been tested on previous minor branches.

PR Checklist

Note: Please do not remove items. Mark items as done [x] or use strikethrough if you believe they are not relevant

  • Linked to a relevant issue. Eg: Fixes #123 or Updates #123
  • Removed non-atomic or wip commits
  • Filled in the Release Note section above
  • Added any relevant branches to cherry-pick
  • Modified the docs to match changes

@waciumawanjohi waciumawanjohi force-pushed the cartotest-supplychains branch from 893b440 to 1924034 Compare June 20, 2023 15:01
@waciumawanjohi
Turn cartotest Expectation into an interface
067cd87
@waciumawanjohi
SupplyChain interface for Cartotest
298b744
@waciumawanjohi
Supply a set of supply chain file paths
9c85699 
Can pass in ytt values as well
@waciumawanjohi
Split large file
ed109da
@waciumawanjohi
Refactor replaceIfFound
b4e6411
@waciumawanjohi
Update cli suite expected locating
b24c62c
@waciumawanjohi
Change cartotesting workload to an interface
b13eabd
@waciumawanjohi
Turn Givens.Template into an interface
3cab13e
@waciumawanjohi
Rename interface
998b205
@waciumawanjohi
Rename supplychain interface
a8bacbb
@waciumawanjohi
BlueprintParams as an interface
261b150
@waciumawanjohi
Move functions
902170d
@waciumawanjohi
Change method to function
1aea4f5
@waciumawanjohi
Change BlueprintInputs into an interface
fb752a2
@waciumawanjohi
Blueprint Params and Inputs nested under MockSupplyChain
4f6f036
@waciumawanjohi
Move method
b5a55a9
@waciumawanjohi
Change pointers on methods
7feb8ad
@waciumawanjohi
Move functions
a902068
@waciumawanjohi
Turn SupplyChain into an interface implemented by mock and actual sup…
6567cc8 
…ply chains
@waciumawanjohi
Rename Expectations and Given
0bc65ed
@waciumawanjohi
Rename SupplyChainFileSet
3d12655
@waciumawanjohi
Add fields to supply chain set
e7e0c89
@waciumawanjohi
Rename Expectation interface implementations
a5b685c
@waciumawanjohi
Rename Expectation fields
98f2b09
@waciumawanjohi
First passing actual supply chain test
5e834a9
@waciumawanjohi
Change specification of ytt file for cli cartotests
713eb92
@waciumawanjohi
Nest template cli fields as they are in new template struct
437bd78
@waciumawanjohi
Nest mockSupplyChain CLI fields
95333e0
@waciumawanjohi
Nest metadata and givens in CLI info file
537abe1
@waciumawanjohi
Test CLI tests with go test
b63fcc1
@waciumawanjohi
Begin moving CLI TestCase Population to functions
851d01e
@waciumawanjohi
CLI TestCase Population in function
e23ee7c
@waciumawanjohi
Split cli-suite-builder file into suite and case
7dc01bf
@waciumawanjohi
Rename variables
3ee3500
@waciumawanjohi
Refactor populate testCase template
0974f5e
@waciumawanjohi
Further refactor populate testCase template
6f381ba
@waciumawanjohi
Rename function
0a1abe1
@waciumawanjohi
Even further refactor populate testCase template
02712a8
@waciumawanjohi
populate TestCase SupplyChain function
355c723
@waciumawanjohi
Working cartotest cli with actual supply chain
4edca4f
@waciumawanjohi
Create Comparison Option Field
7eb9da4
@waciumawanjohi
CompareOptions yields cmp.Options
5a32138
@waciumawanjohi
Cartotest CLI uses compareOptions
66ce6ba
@waciumawanjohi
Reorder yaml files
46b8456
@waciumawanjohi
Lint
ecec9d6
@waciumawanjohi
Cartotest CLI can leverage number conversion function
aa778d8
@waciumawanjohi
Simplify cartotest cli
1922538 
Deprecate the 'templates' command
@waciumawanjohi
Ensure targetResource references provided template
d121031
@waciumawanjohi
Simplify language
c38f2f9 
Cartesting tests are Test rather than TemplateTestCase

Similarly Suite rather than TemplateTestSuite
@waciumawanjohi
Convert Blueprint params/inputs to SupplyChain params/inputs
ec306e0
@waciumawanjohi waciumawanjohi marked this pull request as ready for review June 20, 2023 21:25
@waciumawanjohi waciumawanjohi force-pushed the cartotest-supplychains branch from fe99733 to ec306e0 Compare June 20, 2023 21:26
@waciumawanjohi waciumawanjohi merged commit c3aca9b into main Jun 21, 2023
@waciumawanjohi waciumawanjohi deleted the cartotest-supplychains branch June 21, 2023 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@idoru idoru idoru approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@waciumawanjohi @idoru