Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin go version for GitHub actions #1267

Merged
merged 2 commits into from
Jun 20, 2023

Conversation

waciumawanjohi
Copy link
Contributor

@waciumawanjohi waciumawanjohi commented Jun 14, 2023

Changes proposed by this PR

Github actions are currently broken by go 1.19.10. We delete files and then run make generate to recreate them. Track the bug in counterfeiter here: maxbrunsfeld/counterfeiter#246

Release Note

Cherry-pick branches

All

PR Checklist

Note: Please do not remove items. Mark items as done [x] or use strikethrough if you believe they are not relevant

  • Linked to a relevant issue. Eg: Fixes #123 or Updates #123
  • Removed non-atomic or wip commits
  • [ ] Filled in the Release Note section above
  • Added any relevant branches to cherry-pick
  • [ ] Modified the docs to match changes

@waciumawanjohi waciumawanjohi marked this pull request as ready for review June 14, 2023 21:13
with:
go-version-file: 'go.mod'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you raise a ticket to remind us to put this back?

Copy link
Member

@squeedee squeedee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the one comment to add a ticket to revert this when it's no longer a problem (perhaps on the upstream fix ticket you already have open)

@waciumawanjohi waciumawanjohi merged commit 52a32e0 into main Jun 20, 2023
@waciumawanjohi waciumawanjohi deleted the pin-go-version-for-github-actions branch June 20, 2023 14:47
@waciumawanjohi waciumawanjohi mentioned this pull request Jul 10, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants