Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delivery validations #245

Merged
merged 1 commit into from
Oct 20, 2021
Merged

Delivery validations #245

merged 1 commit into from
Oct 20, 2021

Conversation

squeedee
Copy link
Member

@squeedee squeedee commented Oct 19, 2021

Add a validation to ensure uniqueness of Delivery.spec.resources[].name

See #244

@netlify
Copy link

netlify bot commented Oct 19, 2021

✔️ Deploy Preview for elated-stonebraker-105904 canceled.

🔨 Explore the source changes: 34c864e

🔍 Inspect the deploy log: https://app.netlify.com/sites/elated-stonebraker-105904/deploys/616f3610ac2e480007b03dcd

@squeedee squeedee force-pushed the 244-delivery-validations branch from 08d88b7 to a25eb44 Compare October 19, 2021 19:13
@squeedee squeedee marked this pull request as ready for review October 19, 2021 20:38
- split webhook configuration as well

[#220]

Co-authored-by: Todd Ritchie <tritchie@vmware.com>
@squeedee squeedee force-pushed the 244-delivery-validations branch from a25eb44 to 34c864e Compare October 19, 2021 21:18
Copy link
Contributor

@cirocosta cirocosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 😁

@squeedee squeedee merged commit f4e7507 into main Oct 20, 2021
@squeedee squeedee deleted the 244-delivery-validations branch October 20, 2021 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants