Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a make pre-push target #297

Merged
merged 2 commits into from
Nov 4, 2021
Merged

Add a make pre-push target #297

merged 2 commits into from
Nov 4, 2021

Conversation

squeedee
Copy link
Member

@squeedee squeedee commented Nov 4, 2021

pre-push ensures that all generated content, copywrites and lints are
run and ends with an error if a mutation is caused.

usage:

  1. with all your work added and committed (or stashed)
  2. run make pre-push && git push
  3. if any mutations occur, you can amend/rewrite or otherwise adjust your commits to include the changes

pre-push ensures that all generated content, copywrites and lints are
run and ends with an error if a mutation is caused.

usage:
  1. with all your work added and committed (or stashed)
  2. run `make pre-push && git push`
  3. if any mutations occur, you can amend/rewrite or otherwise adjust your commits to include the changes
@netlify
Copy link

netlify bot commented Nov 4, 2021

✔️ Deploy Preview for elated-stonebraker-105904 ready!

🔨 Explore the source changes: 339ab07

🔍 Inspect the deploy log: https://app.netlify.com/sites/elated-stonebraker-105904/deploys/6183e6332ee95e0007f8ab3f

😎 Browse the preview: https://deploy-preview-297--elated-stonebraker-105904.netlify.app

Copy link
Contributor

@cirocosta cirocosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 😁

should we update CONTRIBUTING.md to mention it, though?

@squeedee
Copy link
Member Author

squeedee commented Nov 4, 2021

should we update CONTRIBUTING.md to mention it, though?

Agreed, going to add that now.

Copy link
Contributor

@cirocosta cirocosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

contributing looks good! thx!

@squeedee squeedee merged commit 71fe1fd into main Nov 4, 2021
@squeedee squeedee deleted the precommit-target branch November 4, 2021 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants