23 informers deliverable #314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for elated-stonebraker-105904 canceled. 🔨 Explore the source changes: 7f1aa7f 🔍 Inspect the deploy log: https://app.netlify.com/sites/elated-stonebraker-105904/deploys/618c21c08b98b00007d2cdb0 |
squeedee
force-pushed
the
23-informers-deliverable
branch
from
723c1f8 to
7482de3
Compare
- Backofftests made sense when we used errors and timeouts to ensure reconcile was called again. - Now when a reconcile error occurs, backoff will be shortcircuited by informers. Testing informers work correctly is all we need. [#23] Co-authored-by: Emily Johnson <emjohnson@vmware.com>
- We're dependent on APIServer + our countroller resolving this stamp in under a second, which just doesn't always happen. Co-authored-by: Emily Johnson <emjohnson@vmware.com>
[#23] Co-authored-by: Emily Johnson <emjohnson@vmware.com>
squeedee
force-pushed
the
23-informers-deliverable
branch
from
0ffe53c to
7ccd223
Compare
squeedee
approved these changes
Nov 9, 2021
cirocosta
reviewed
Nov 10, 2021
pkg/registrar/registrar.go
Outdated
| }) | ||
| if err != nil { | ||
| return fmt.Errorf("controller new: %w", err) | ||
| } | ||
|
|
||
| reconciler.AddTracking(&external.ObjectTracker{ |
There was a problem hiding this comment.
one implicit detail of using external.ObjectTracker is that one can actually "pause the watching" by making use of clusterapi's paused annotation:
// PausedAnnotation is an annotation that can be applied to any Cluster API
// object to prevent a controller from processing a resource.
//
// Controllers working with Cluster API objects must check the existence of this annotation
// on the reconciled object.
PausedAnnotation = "cluster.x-k8s.io/paused"used as a predicate in
log.Info("Adding watcher on external object", "GroupVersionKind", gvk.String())
err := o.Controller.Watch(
&source.Kind{Type: u},
handler,
predicates.ResourceNotPaused(log),
)
martyspiewak
approved these changes
Nov 10, 2021
emmjohnson
force-pushed
the
23-informers-deliverable
branch
from
d935c75 to
7f1aa7f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.