example: match source-controller's duration unmarshalling #327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as described in #95, given that the unmarshalling that source-controller performs doesn't match what we're trying to submit, we end up forcing reconciliation to happen over and over again (better described in the issue). now that we make use of informers rather than a 5s polling interval, the issue becomes even more apparent. ultimately we should figure out #95, but for now, this fix prevents a big unecessary reconciliation load. Signed-off-by: Ciro S. Costa <ciroscosta@vmware.com>
|
✔️ Deploy Preview for elated-stonebraker-105904 canceled. 🔨 Explore the source changes: 93d4be0 🔍 Inspect the deploy log: https://app.netlify.com/sites/elated-stonebraker-105904/deploys/618bd8e4307c020007a5fe35 |
cirocosta
changed the title
emmjohnson
approved these changes
Nov 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as described in #95,
given that the unmarshalling that source-controller performs doesn't
match what we're trying to submit, we end up forcing reconciliation to
happen over and over again (better described in the issue).
now that we make use of informers rather than a 5s polling interval, the
issue becomes even more apparent.
ultimately we should figure out #95, so I'm a bit conflicted about even getting
this in tbh, but for now this fix prevents a big unnecessary reconciliation load
that will eventually be addressed.
Signed-off-by: Ciro S. Costa ciroscosta@vmware.com