hack: use double space in ytt checksum check #333
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
even though standard gnu coreutils accepts taking a single space as the
separator, that's not true for busybox.
by making sure we're passing a double space everywhere we compute a
checksum, we """guarantee""" to be good not only w/ gnu, but also
busybox-based ones (like alpine etc).
(see https://github.com/mirror/busybox/blob/15f7d618ea7f8c3a0277c98309268b709e20d77c/coreutils/md5_sha1_sum.c#L296)
ps.: in case you're wondering why this isn't captured by CI, it's because
we have github running based of ubuntu: