Remove bad test #388
Merged
Remove bad test #388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for elated-stonebraker-105904 canceled. 🔨 Explore the source changes: dd7515f 🔍 Inspect the deploy log: https://app.netlify.com/sites/elated-stonebraker-105904/deploys/619d32ad70513200085870a2 |
emmjohnson
approved these changes
Nov 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test is not testing desired behavior- we don't want to re-stamp if the selected object changes.
This would create problems if, for example, you are creating a runnable to run tests against a deployment and selecting a pipeline. If the tests pass and the deployment is deleted and then the selected pipeline changes, you wouldn't want the tests to run again because the deployment no longer exists.
This test was flakey and only ever passed because of a race condition.