Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better css #412

Merged
merged 4 commits into from
Dec 1, 2021
Merged

Better css #412

merged 4 commits into from
Dec 1, 2021

Conversation

squeedee
Copy link
Member

@squeedee squeedee commented Dec 1, 2021 •
edited
Loading

Improve docs

  • Remove superfluous junk pages
  • Fix missing <strong> element
  • Code highlighting
    • Use github code highlighting
    • Copy Carvel's look (no border, stronger colors)
  • Don't show docs 'getting started' on the docs pages.

Rasheed Abdul-Aziz added 4 commits November 30, 2021 16:56
Remove superfluous junk from docs
27bfccc
Improve doc appearance
fc12a01 
- fix absent `strong`
- use github syntax highlighting
- use carvel's better syntax boxes
remove unused sections
dfe45c6
don't link to docs from within docs
81d13e2
@netlify
Copy link

netlify bot commented Dec 1, 2021 •
edited
Loading

✔️ Deploy Preview for elated-stonebraker-105904 ready!

🔨 Explore the source changes: 81d13e2

🔍 Inspect the deploy log: https://app.netlify.com/sites/elated-stonebraker-105904/deploys/61a6ca2c8f414800083e87e5

😎 Browse the preview: https://deploy-preview-412--elated-stonebraker-105904.netlify.app

@DanieldeR
Copy link
Contributor

I just noticed that the home, community and blog pages all have a max-width of 980px, which the docs page does not. It looks like it's there in the current version of the docs as well, not sure if it's something that could be fixed with this PR or perhaps opening another issue?

DanieldeR
DanieldeR approved these changes Dec 1, 2021
View reviewed changes
Copy link
Contributor

@DanieldeR DanieldeR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. The code block updates are much better.

@squeedee
Copy link
Member Author

squeedee commented Dec 1, 2021 •
edited
Loading

I just noticed that the home, community and blog pages all have a max-width of 980px, which the docs page does not. It looks like it's there in the current version of the docs as well, not sure if it's something that could be fixed with this PR or perhaps opening another issue?

@DanieldeR Was going to change it but the side nav and helpful links all get messed up, will need more than a moment's effort to fix.

@squeedee squeedee merged commit f26c921 into main Dec 1, 2021
@squeedee squeedee deleted the better-css branch December 1, 2021 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanieldeR DanieldeR DanieldeR approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@squeedee @DanieldeR