414 informers use best match #423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for elated-stonebraker-105904 canceled. 🔨 Explore the source changes: a37ccdb 🔍 Inspect the deploy log: https://app.netlify.com/sites/elated-stonebraker-105904/deploys/61ae1b35395b7e000886942c |
martyspiewak
force-pushed
the
414-informers-use-best-match
branch
from
d53e66a to
95521f1
Compare
|
|
||
| var selectorGetters []repository.SelectorGetter | ||
| for _, item := range scList.Items { | ||
| item := item |
There was a problem hiding this comment.
Not blocking:
Is this just to create a copy of the object? Would persistentItem := item.DeepCopy() suit? Would it be more grokkable?
There was a problem hiding this comment.
I think that would work too but I was trying to be consistent with the way the controller finds the best matching SC (see here)
waciumawanjohi
requested changes
Dec 3, 2021
martyspiewak
force-pushed
the
414-informers-use-best-match
branch
from
95521f1 to
a37ccdb
Compare
waciumawanjohi
approved these changes
Dec 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #414