Fix create/update bug #493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for elated-stonebraker-105904 ready! 🔨 Explore the source changes: f1d2311 🔍 Inspect the deploy log: https://app.netlify.com/sites/elated-stonebraker-105904/deploys/61bcb8b2a82b920008648202 😎 Browse the preview: https://deploy-preview-493--elated-stonebraker-105904.netlify.app |
cirocosta
reviewed
Dec 16, 2021
* List by GVK, namespace, and labels instead of passing object and listing by it's characteristics
martyspiewak
force-pushed
the
484-create-instead-of-update
branch
from
e385c64 to
8f21296
Compare
Co-authored-by: Marty Spiewak <mspiewak@vmware.com>
Co-authored-by: Marty Spiewak <mspiewak@vmware.com>
Co-authored-by: Marty Spiewak <mspiewak@vmware.com>
Co-authored-by: Marty Spiewak <mspiewak@vmware.com>
Co-authored-by: Marty Spiewak <mspiewak@vmware.com>
# Conflicts: # pkg/realizer/deliverable/component_test.go # pkg/realizer/workload/component_test.go # pkg/repository/repository.go # pkg/repository/repository_test.go # pkg/repository/repositoryfakes/fake_repository.go
emmjohnson
changed the title
squeedee
approved these changes
Dec 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed by this PR
carto.run/runnable-namelabel onlycloses #484
Release Notes
Developer service account now requires Get permission
PR Checklist
Note: Please do not remove items. Mark items as done
[x]or usestrikethroughif you believe they are not relevantFixes #123orUpdates #123wipcommits