Remove error log when resource is deleted #640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for elated-stonebraker-105904 canceled. 🔨 Explore the source changes: cd6a1b4 🔍 Inspect the deploy log: https://app.netlify.com/sites/elated-stonebraker-105904/deploys/620ec0ede109140008242fcf |
scothis
reviewed
Feb 18, 2022
| @@ -393,7 +393,6 @@ func (r *repository) getObject(ctx context.Context, name string, namespace strin | |||
| ) | |||
| if err != nil { | |||
| namespacedName := getNamespacedName(name, namespace) | |||
| log.Error(err, "failed to get object from api server", "object", namespacedName) | |||
There was a problem hiding this comment.
it might still be worth logging the error when the error is not a NotFound error
There was a problem hiding this comment.
This is an internal method and all of the public methods which call it already handle that error logging.
emmjohnson
approved these changes
Feb 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed by this PR
Controller no longer logs an error when a resource has been deleted.
closes #586
Release Note
Controller no longer logs an error when a resource has been deleted.
PR Checklist
Note: Please do not remove items. Mark items as done
[x]or usestrikethroughif you believe they are not relevantFixes #123orUpdates #123wipcommits