Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add conditions to owner.status.resource[x] #816

Merged
merged 19 commits into from
Apr 21, 2022

Conversation

emmjohnson
Copy link
Contributor

@emmjohnson emmjohnson commented Apr 19, 2022

Changes proposed by this PR

  • Add conditions to owner.status.resource[x]
  • Remove duplication from errors at realizer/workload/errors.go and realizer/deliverable/errors.go - all errors are now located at errors/errors.go
    • Will do the same for remaining duplicate errors in another PR
  • Remove duplication from conditions at controller/workload/conditions.go and controller/deliverable/conditions.go - all conditions are now located at conditions/*
    • Will do the same for remaining duplicate conditions in another PR
  • Move workload reconciler and deliverable reconciler to controllers/*
    • Will do the same for remaining reconcilers in another PR

closes #809

Release Note

PR Checklist

Note: Please do not remove items. Mark items as done [x] or use strikethrough if you believe they are not relevant

  • Linked to a relevant issue. Eg: Fixes #123 or Updates #123
  • Removed non-atomic or wip commits
  • Filled in the Release Note section above
  • Modified the docs to match changes

@emmjohnson emmjohnson changed the title 809 owner status conditions Add conditions to owner.status.resource[x] Apr 19, 2022
@emmjohnson emmjohnson marked this pull request as ready for review April 19, 2022 21:00
@emmjohnson emmjohnson requested a review from idoru April 20, 2022 13:55
pkg/realizer/workload/realizer.go Outdated Show resolved Hide resolved
pkg/errors/errors.go Outdated Show resolved Hide resolved
@emmjohnson emmjohnson enabled auto-merge (squash) April 21, 2022 14:37
@emmjohnson emmjohnson mentioned this pull request Apr 21, 2022
4 tasks
@emmjohnson emmjohnson merged commit 61b10e9 into main Apr 21, 2022
@emmjohnson emmjohnson deleted the 809-owner-status-conditions branch April 21, 2022 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show stamped condition for each resource workload status
2 participants