Singular realizer

[squeedee]

consolidate much duplication across delivery and supply chain

[cirocosta]

I noticed that in deliverable_reconciler we're doing

func buildDeliverableResourceLabeler(owner, blueprint client.Object) realizer.ResourceLabeler {
        return func(resource realizer.OwnerResource) templates.Labels {
                return templates.Labels{
                        "carto.run/deliverable-name":      owner.GetName(),
                        "carto.run/deliverable-namespace": owner.GetNamespace(),
                        "carto.run/delivery-name":         blueprint.GetName(),
                        "carto.run/resource-name":         resource.Name,
                        "carto.run/template-kind":         resource.TemplateRef.Kind,
                        "carto.run/cluster-template-name": resource.TemplateRef.Name,
                }
        }
}

while here we're actually doing the switch on the type - is there a particular reason for such difference?

[cirocosta]

for

func MakeSupplychainOwnerResources(supplyChain *v1alpha1.ClusterSupplyChain) []OwnerResource {
	var resources []

we pass straight v1alpha1.ClusterSupplyChain in there - given that build(Deliverable|Workload) already includes the concrete type in the name of the function itself, wdyt of passing *v1alpha1.(deliverable|workload) in the args directly?

(assuming we want to keep the distinct methods)

[squeedee]

@idoru I dont think we need the switch on type at all? the reconciler is building for Workloads/SCs only?

[idoru]

good spot. forgot to remove the switch when we split it.

[cirocosta]

overall lgtm! just some nitpicking
awesome to see the cuts

!