Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

486 runnable output bug #876

Merged
merged 17 commits into from
May 27, 2022
Merged

486 runnable output bug #876

merged 17 commits into from
May 27, 2022

Conversation

squeedee
Copy link
Member

@squeedee squeedee commented May 27, 2022 •
edited
Loading

Change the behaviour of runnable's outputs:

  1. outputs come from the latest StampedObject with a succeeded:true status. objects without a suceeded status are ignored.
  2. not specifying outputs is legal - supports terminal/throwaway tasks

@squeedee squeedee marked this pull request as ready for review May 27, 2022 14:18
@squeedee squeedee enabled auto-merge (squash) May 27, 2022 14:21
@squeedee squeedee merged commit 8a58a84 into main May 27, 2022
@squeedee squeedee deleted the 486-runnable-output-bug branch May 27, 2022 19:16
@squeedee squeedee mentioned this pull request Aug 29, 2022
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cirocosta cirocosta cirocosta left review comments

@idoru idoru idoru approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@squeedee @idoru @cirocosta