812 owner healthy status #877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cirocosta
reviewed
May 27, 2022
cirocosta
approved these changes
May 27, 2022
ClusterTemplate resources are now only considered healthy when they have a stamped object. [#812]
idoru
force-pushed
the
812-owner-healthy-status
branch
from
2e0719b to
dcb8e35
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed by this PR
Owners now report
ResourcesHealthycondition which summarizes theHealthycondition of its owned resources.When any resource has a
Healthycondition withUnknownstatus, the status ofResourcesHealthyisUnknown.If not, when any resource has a
Healthycondition withFalsestatus, the status ofResourcesHealthyisFalse.Else, all resources have a
Healthycondition ofTrueand the status ofResourcesHealthyisTrue.Objects stamped with
ClusterTemplatewithout ahealthRuleare now only considered to have aHealthywith a status ofTruewhen the object is successfully created.builds on PR #875
updates #812
Release Note
Owners report
ResourcesHealthycondition to reflect overallHealthycondition of owned resourcesPR Checklist
Note: Please do not remove items. Mark items as done
[x]or usestrikethroughif you believe they are not relevantFixes #123orUpdates #123wipcommits