[velero] Remove helm hooks for the custom resources #490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jenting
force-pushed
the
remove-helm-hook
branch
from
42be236
to
c083572
Compare
The PR #414 have moved the upgrade CRD job from post hook to pre hook to ensure that the custom resources create/upgrade after the CRD installed/upgraded. Therefore, the helm hooks for the custom resources are no longer required includes - backupstoragelocations.velero.io - volumesnapshotlocations.velero.io - schedules.velero.io Signed-off-by: JenTing Hsiao <hsiaoairplane@gmail.com>
jenting
force-pushed
the
remove-helm-hook
branch
from
c083572
to
73f33fe
Compare
This was referenced Aug 14, 2023
jenting
force-pushed
the
remove-helm-hook
branch
4 times, most recently
from
eceb19d
to
7bde6ef
Compare
jenting
force-pushed
the
remove-helm-hook
branch
3 times, most recently
from
08c59d2
to
466fff4
Compare
Signed-off-by: JenTing Hsiao <hsiaoairplane@gmail.com>
jenting
force-pushed
the
remove-helm-hook
branch
from
466fff4
to
06a6249
Compare
ywk253100
approved these changes
Aug 17, 2023
qiuming-best
approved these changes
Aug 17, 2023
cwrau
added a commit
to teutonet/teutonet-helm-charts
that referenced
this pull request
Aug 24, 2023
delete old backupstoragelocations like they recommend in vmware-tanzu/helm-charts#490 replaces #524
cwrau
added a commit
to teutonet/teutonet-helm-charts
that referenced
this pull request
Aug 24, 2023
delete old backupstoragelocations like they recommend in vmware-tanzu/helm-charts#490 replaces #524
cwrau
added a commit
to teutonet/teutonet-helm-charts
that referenced
this pull request
Aug 24, 2023
delete old backupstoragelocations like they recommend in vmware-tanzu/helm-charts#490 replaces #524
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Special notes for your reviewer:
The PR #414 have moved the upgrade CRD job from post hook to pre hook to ensure that the custom resources create/upgrade after the CRD installed/upgraded.
Therefore, the helm hooks for the custom resources are no longer required includes
Fixes #298 #392 #435 #462
Important
It's a breaking change during helm upgrade because the backupstoragelocations.velero.io, volumesnapshotlocations.velero.io, schedules.velero.io which were created by helm hooks does not includes the two annotations
Removing the helm hooks, the helm upgrade requires the above two annotations existed.
The workaround is manually remove the backupstoragelocations.velero.io, volumesnapshotlocations.velero.io, schedules.velero.io and recreated by helm upgrade.
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
[velero])