Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace ansi_term dependency in Pinniped-proxy #5357

Closed
castelblanque opened this issue Sep 19, 2022 · 1 comment · Fixed by #5445
Closed

Replace ansi_term dependency in Pinniped-proxy #5357

castelblanque opened this issue Sep 19, 2022 · 1 comment · Fixed by #5445
Assignees
@absoludity
Labels
component/pinniped-proxy Issue related to kubeapps integration with pinniped-proxy kind/enhancement An issue that reports an enhancement for an implemented feature rust Pull requests that update Rust code
Milestone
Update pinniped-p...

Comments

@castelblanque
Copy link
Collaborator

Summary
Replace ansi_term dependency in the Pinniped-proxy service.

Background and rationale
Dependabot is warning that Rust's dependency ansi_term is unmaintained. Project hasn't been updated for at least three years.
It is not a direct dependency in pinniped-proxy, but a dependency of clap v2, which in turn is a dependency of structopt.
Structopt is not maintained either (see their pinned issue).

Dependabot is warning that it is a critical issue.
image

Description
A feasible solution is to migrate structopt to clap v3. There is a migration guide here.

Acceptance criteria
ansi_term is not used anymore.
@kubeapps-bot kubeapps-bot moved this to 🗂 Backlog in Kubeapps Sep 19, 2022
@castelblanque castelblanque added kind/enhancement An issue that reports an enhancement for an implemented feature rust Pull requests that update Rust code component/pinniped-proxy Issue related to kubeapps integration with pinniped-proxy labels Sep 19, 2022
@ppbaena ppbaena added this to the Technical debt milestone Sep 26, 2022
@ppbaena ppbaena moved this from 🗂 Backlog to 🗒 Todo in Kubeapps Sep 26, 2022
@absoludity
Copy link
Contributor

Yep, with the work I've been doing with https://github.com/vmware/database-stream-processor/ I've been using clap v3 directly after seeing structopt's functionality was now included there, and had noted to come back and do the same here. Thanks!

@absoludity absoludity moved this from 🗒 Todo to 🏗 In Progress in Kubeapps Oct 9, 2022
absoludity added a commit to absoludity/kubeapps that referenced this issue Oct 9, 2022
@absoludity
[pinniped-proxy] Update from structopt to clapv4. Fixes vmware-tanzu#…
bb3d6c1 
…5357

Signed-off-by: Michael Nelson <minelson@vmware.com>
@absoludity absoludity mentioned this issue Oct 9, 2022
Merged
@absoludity absoludity moved this from 🏗 In Progress to 🔎 In Review in Kubeapps Oct 10, 2022
absoludity added a commit that referenced this issue Oct 10, 2022
@absoludity
[pinniped-proxy] Update from structopt to clapv4. Fixes #5357
c54c977 
Signed-off-by: Michael Nelson <minelson@vmware.com>
absoludity added a commit that referenced this issue Oct 19, 2022
@absoludity
[pinniped-proxy] Update from structopt to clapv4. Fixes #5357 (#5445)
ed826f7 
* [pinniped-proxy] Update from structopt to clapv4. Fixes #5357

Signed-off-by: Michael Nelson <minelson@vmware.com>

* Fix clap deprecations.

Signed-off-by: Michael Nelson <minelson@vmware.com>

* Add basic CLI test for pinniped-proxy.

Signed-off-by: Michael Nelson <minelson@vmware.com>

* Add trycmd CLI test to make it easier in the future to extend.

Signed-off-by: Michael Nelson <minelson@vmware.com>

* Add license info to new files.

Signed-off-by: Michael Nelson <minelson@vmware.com>

Signed-off-by: Michael Nelson <minelson@vmware.com>
Repository owner moved this from 🔎 In Review to ✅ Done in Kubeapps Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@absoludity absoludity

Labels
component/pinniped-proxy Issue related to kubeapps integration with pinniped-proxy kind/enhancement An issue that reports an enhancement for an implemented feature rust Pull requests that update Rust code
Projects
Kubeapps
Archived in project
Milestone
Update pinniped-proxy service
Development

Successfully merging a pull request may close this issue.

[pinniped-proxy] Update from structopt to clapv4. Fixes #5357 vmware-tanzu/kubeapps
3 participants
@absoludity @ppbaena @castelblanque