Added GCP auth plugin #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/lgtm. Thanks @arapulido I am taking the glide conflict and landing the PR 🛬 |
ngtuna
approved these changes
Nov 7, 2017
arapulido
pushed a commit
to arapulido/kubeapps
that referenced
this pull request
Feb 13, 2018
If the logout request does not complete in time, the browser does not update the cookie as expired. We now wait for the logout request to succeed before reloading fixes vmware-tanzu#16
prydonius
pushed a commit
that referenced
this pull request
Feb 23, 2018
do not expose ingress controller to public
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As explained at kubernetes/client-go#242 in order to make client-go auth correctly in a GKE cluster, the GCP auth plugin needs to be added as dependency.
Reviewer: please review per commit (as most of the changes are vendorized dependencies)
Fixes issue #15