Update documentation about enabling RBAC in minikube #498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Actually now I am not sure if this is needed. Doesn't kubeadm now bootstraps with RBAC enabled by default? cc/ @prydonius @andresmgot |
|
@migmartri I wasn't 100% sure tbh, but indeed it looks like from 0.26+ kubeadm is the default bootstrapper and RBAC is enabled by default: kubernetes/minikube#1722 (comment). |
|
Can you update the doc to just have |
|
yes, I confirm that RBAC is enabled by default in the latest minikube (I tried with v0.28.2) so |
prydonius
suggested changes
Aug 22, 2018
docs/developer/tiller-proxy.md
Outdated
| @@ -44,7 +44,7 @@ This builds the `tiller-proxy` binary in the working directory. | |||
| If you are using Minikube it is important to start the cluster enabling RBAC (in order to check the authorization features): | |||
|
|
|||
| ``` | |||
| minikube start --extra-config=apiserver.Authorization.Mode=RBAC | |||
| minikube start --extra-config=apiserver.authorization-mode=RBAC | |||
There was a problem hiding this comment.
remove --extra-config parameter
|
https://kubernetes.io/docs/setup/minikube/#examples should also be updated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minikube 0.26+ fails to start if the flag
--Authorization.Modeis passed with the errorThis updates the docs to use the configuration that Kubeadm understands.
kubernetes/minikube#2712 (comment)