Fix GHA release workflow #5717
Merged
Fix GHA release workflow #5717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jesús Benito Calzada <bjesus@vmware.com>
✅ Deploy Preview for kubeapps-dev canceled.Built without sensitive environment variables
|
beni0888
added
component/ci
antgamdia
approved these changes
Nov 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jesús Benito Calzada bjesus@vmware.com
Description of the change
This commit aims to fix the
Release Pipelineof the GHA workflows (better said, to make it support testing releases, those triggered by tags following the patterntest-vX.Y.Z). Currently, it is failing because in theKubeapps Generalworkflow, we are setting therunning_on_tagoutput variable of thesetupjob based on whether the Git ref type istagand it matches the patternvX.Y.Z. Given that we are controlling what tag patterns can trigger a release in theRelease Pipelineworkflow, it doesn't make sense to have this condition, as we need to make sure that it's in sync with what there is in the workflow conditions, and it's error-prone.Benefits
The
Release Pipelineworks as expected and supports testing releases.Possible drawbacks
None.
Applicable issues