Simplify release-related logic in GHA's kubeapps general pipeline #5718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jesús Benito Calzada <bjesus@vmware.com>
✅ Deploy Preview for kubeapps-dev canceled.Built without sensitive environment variables
|
beni0888
added
component/ci
antgamdia
approved these changes
Nov 25, 2022
Signed-off-by: Jesús Benito Calzada <bjesus@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jesús Benito Calzada bjesus@vmware.com
Description of the change
This commit aims to simplify the logic in the GHA's Kubeapps General workflow. Currently, we have some logic that checks if the pipeline has been triggered by a tag pushed to the repo, and if it is, we run some jobs: push_images, sync_charts, release, etc. As we already have a top-level workflow
kubeapps-release.ymlthat internally uses the general workflow, and only runs when a tag following the release pattern is pushed to the repo, we can just introduce an input parameter in the general workflow that controls whether those jobs should be run or not, instead of relying on the logic residing in the general pipeline.Benefits
GHA's workflows
kubeapps-general.yamlandkubeapps-release.ymlare simpler to understand and maintain.Possible drawbacks
None.
Applicable issues