Prequel to upgrading to react-router 6 #6453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for kubeapps-dev canceled.
|
absoludity
force-pushed
the
react-router-upgrade-1
branch
from
b13c806
to
7924439
Compare
Signed-off-by: Michael Nelson <minelson@vmware.com>
… concepts. Signed-off-by: Michael Nelson <minelson@vmware.com>
Signed-off-by: Michael Nelson <minelson@vmware.com>
Signed-off-by: Michael Nelson <minelson@vmware.com>
absoludity
force-pushed
the
react-router-upgrade-1
branch
from
dfe2a96
to
22da25c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Updates our routing with some preparation for the react-router upgrade. This involved:
Routeout of the PrivateRoute component and into the routes directly, as these need to be top-level for react-router 6See https://reactrouter.com/en/main/upgrading/v5
Benefits
One step closer to updating to react-router 6.
Starts transition from enzyme to react testinglibrary.
Applicable issues