-
Notifications
You must be signed in to change notification settings - Fork 706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed baseUrl to use relative path to support URL subpath #6525
Conversation
✅ Deploy Preview for kubeapps-dev canceled.Built without sensitive environment variables
|
@jcatana, we have received your signed contributor license agreement. The review is usually completed within a week, but may take longer under certain circumstances. Another comment will be added to the pull request to notify you when the merge can proceed. |
Thanks @jcatana . I'm assuming you tested this in real life and verified that it fixes the issue without breaking anything else. Looks like we just switched to an absolute path when upgrading as mentioned on the issue. I'll let the CI tooling run for now, while you get to do the joys of signing the CLA (apologies for the friction to contribute :) ) |
Looks good @jcatana , once the CLA is done I'll approve and land. Thanks! |
@jcatana, we have received your signed contributor license agreement. The review is usually completed within a week, but may take longer under certain circumstances. Another comment will be added to the pull request to notify you when the merge can proceed. |
Updated. Autocomplete only puts street & number in "address" fields. Maybe a fix to the CLA if you require all that info. Can I make a PR on your CLA form? 🤣 |
@jcatana, VMware has approved your signed contributor license agreement. |
I wish - not something we control. Thanks again! |
Description of the change
Fixes static
baseUrl: /...
to be relativebaseUrl: ./...
Benefits
Restores previous functionality of working behind url subpath aka ingress
Possible drawbacks
Unknown
Applicable issues
Additional information