Update golang to 1.22 #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hold upgrading k8s 1.30 because of this kubernetes-sigs/controller-runtime#2788 |
lubronzhan
force-pushed
the
topic/lubron/bump_golang_1.22
branch
4 times, most recently
from
57d1835
to
3a933b8
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #238 +/- ##
==========================================
- Coverage 36.89% 31.01% -5.88%
==========================================
Files 20 31 +11
Lines 2174 2879 +705
==========================================
+ Hits 802 893 +91
- Misses 1314 1916 +602
- Partials 58 70 +12 |
lubronzhan
force-pushed
the
topic/lubron/bump_golang_1.22
branch
5 times, most recently
from
8b0c1bc
to
14b94a5
Compare
sunjayBhatia
reviewed
May 3, 2024
sunjayBhatia
reviewed
May 3, 2024
lubronzhan
force-pushed
the
topic/lubron/bump_golang_1.22
branch
from
14b94a5
to
35edf5a
Compare
|
Integration test should pass once this is merged #241 |
Signed-off-by: Lubron Zhan <lubronzhan@gmail.com>
Signed-off-by: Lubron Zhan <lubronzhan@gmail.com>
Signed-off-by: Lubron Zhan <lubronzhan@gmail.com>
Signed-off-by: Lubron Zhan <lubronzhan@gmail.com>
Signed-off-by: Lubron Zhan <lubronzhan@gmail.com>
Signed-off-by: Lubron Zhan <lubronzhan@gmail.com>
Signed-off-by: Lubron Zhan <lubronzhan@gmail.com>
lubronzhan
force-pushed
the
topic/lubron/bump_golang_1.22
branch
from
f2b699f
to
6ddcc60
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
To update to newest golang 1.22
Which issue(s) this PR fixes:
Fixes #
Describe testing done for PR:
Special notes for your reviewer:
Release note:
New PR Checklist