Skip to content

Commit

Permalink
Update githubaction workflow branch
Browse files Browse the repository at this point in the history
Update githubaction workflow branch to v4.1.0
  • Loading branch information
timdengyun committed May 12, 2024
1 parent ffcd336 commit 9dcb913
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 6 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/makefile.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@ name: Makefile CI

on:
push:
branches: [ main ]
branches: [ v4.1.0 ]
pull_request:
branches: [ main ]
branches: [ v4.1.0 ]

jobs:
build:
Expand All @@ -16,7 +16,7 @@ jobs:
- name: Set up Go
uses: actions/setup-go@v2
with:
go-version: 1.17
go-version: 1.19

- name: Run build
run: make build
Expand Down
5 changes: 2 additions & 3 deletions pkg/controllers/securitypolicy_controller_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,6 @@ func TestSecurityPolicyController_isCRRequestedInSystemNamespace(t *testing.T) {
req = &ctrl.Request{NamespacedName: types.NamespacedName{Namespace: "sys-ns", Name: "dummy"}}

isCRInSysNs, err = r.isCRRequestedInSystemNamespace(&ctx, req)

if err != nil {
t.Fatalf(err.Error())
}
Expand Down Expand Up @@ -209,7 +208,7 @@ func TestSecurityPolicyReconciler_Reconcile(t *testing.T) {
assert.Equal(t, err, ret)

// DeletionTimestamp.IsZero = false, Finalizers doesn't include util.FinalizerName
k8sClient.EXPECT().Get(ctx, gomock.Any(), sp).Return(nil).Do(func(_ context.Context, _ client.ObjectKey, obj client.Object) error {
k8sClient.EXPECT().Get(ctx, gomock.Any(), sp).Return(nil).Do(func(_ context.Context, _ client.ObjectKey, obj client.Object, option ...client.GetOption) error {
v1sp := obj.(*v1alpha1.SecurityPolicy)
time := metav1.Now()
v1sp.ObjectMeta.DeletionTimestamp = &time
Expand All @@ -225,7 +224,7 @@ func TestSecurityPolicyReconciler_Reconcile(t *testing.T) {
patch.Reset()

// DeletionTimestamp.IsZero = false, Finalizers include util.FinalizerName
k8sClient.EXPECT().Get(ctx, gomock.Any(), sp).Return(nil).Do(func(_ context.Context, _ client.ObjectKey, obj client.Object) error {
k8sClient.EXPECT().Get(ctx, gomock.Any(), sp).Return(nil).Do(func(_ context.Context, _ client.ObjectKey, obj client.Object, option ...client.GetOption) error {
v1sp := obj.(*v1alpha1.SecurityPolicy)
time := metav1.Now()
v1sp.ObjectMeta.DeletionTimestamp = &time
Expand Down

0 comments on commit 9dcb913

Please sign in to comment.