Skip to content

Commit

Permalink
Address comments
Browse files Browse the repository at this point in the history
Signed-off-by: Wenqi Qiu <wenqiq@vmware.com>
  • Loading branch information
wenqiq committed Jul 5, 2024
1 parent 9114bf3 commit b471855
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 2 deletions.
7 changes: 6 additions & 1 deletion pkg/controllers/subnet/subnet_controller.go
Original file line number Diff line number Diff line change
Expand Up @@ -83,8 +83,13 @@ func (r *SubnetReconciler) Reconcile(ctx context.Context, req ctrl.Request) (ctr
updateFail(r, &ctx, obj, "")
return ResultRequeue, err
}

if obj.Spec.AccessMode == "" {
obj.Spec.AccessMode = v1alpha1.AccessMode(v1alpha1.AccessModePrivate)
accessMode := v1alpha1.AccessMode(v1alpha1.AccessModePrivate)
if obj.Name == servicecommon.DefaultPodSubnetSet {
accessMode = v1alpha1.AccessMode(vpcNetworkConfig.PodSubnetAccessMode)
}
obj.Spec.AccessMode = accessMode
}
if obj.Spec.IPv4SubnetSize == 0 {
obj.Spec.IPv4SubnetSize = vpcNetworkConfig.DefaultSubnetSize
Expand Down
6 changes: 5 additions & 1 deletion pkg/controllers/subnetset/subnetset_controller.go
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,11 @@ func (r *SubnetSetReconciler) Reconcile(ctx context.Context, req ctrl.Request) (
return ResultRequeue, err
}
if obj.Spec.AccessMode == "" {
obj.Spec.AccessMode = v1alpha1.AccessMode(v1alpha1.AccessModePrivate)
accessMode := v1alpha1.AccessMode(v1alpha1.AccessModePrivate)
if obj.Name == servicecommon.DefaultPodSubnetSet {
accessMode = v1alpha1.AccessMode(vpcNetworkConfig.PodSubnetAccessMode)
}
obj.Spec.AccessMode = accessMode
}
if obj.Spec.IPv4SubnetSize == 0 {
obj.Spec.IPv4SubnetSize = vpcNetworkConfig.DefaultSubnetSize
Expand Down

0 comments on commit b471855

Please sign in to comment.