Refactor loglevel based on debug in configmap #265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dantingl
reviewed
Aug 9, 2023
timdengyun
reviewed
Aug 10, 2023
timdengyun
reviewed
Aug 10, 2023
timdengyun
reviewed
Aug 10, 2023
zhengxiexie
force-pushed
the
log_main
branch
4 times, most recently
from
7b63bd1
to
e9358a9
Compare
timdengyun
reviewed
Aug 15, 2023
zhengxiexie
force-pushed
the
log_main
branch
2 times, most recently
from
d362f12
to
98ae30c
Compare
We hold these truths to be self-evident: log.info -> info, log.v(1).info -> debug, log.error-> error, log.v(2).info-> develop level log If config.Debug=true, then loglevel=1, if command is passed in loglevel and greater than debug loglevel, then the loglevel is overridden. Use another log in config.go.
timdengyun
approved these changes
Sep 4, 2023
zhengxiexie
added a commit
that referenced
this pull request
Sep 4, 2023
Refactor loglevel based on debug in configmap(#265)
zhengxiexie
added a commit
that referenced
this pull request
Sep 4, 2023
Refactor loglevel based on debug in configmap(#265)
TaoZou1
added a commit
that referenced
this pull request
Dec 12, 2023
TaoZou1
added a commit
that referenced
this pull request
Dec 12, 2023
Revert "Refactor loglevel based on debug in configmap(#265)"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to fix Issue: #245
We hold these truths to be self-evident:
log.info -> info, log.v(1).info -> debug, log.error-> error, log.v(2).info-> develop level log
If config.Debug=true, then loglevel=1, if command is passed in loglevel and greater than debug loglevel, then the loglevel is overridden.