Support to create subnetport in subnetset #269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heypnus
force-pushed
the
vpc/subnetset_port_integration
branch
2 times, most recently
from
923b058
to
e5c00b6
Compare
dantingl
previously approved these changes
Aug 10, 2023
lxiaopei
reviewed
Aug 10, 2023
heypnus
force-pushed
the
vpc/subnetset_port_integration
branch
4 times, most recently
from
c0cb5e0
to
3160a74
Compare
1. Adding index by subnet CR uid in subnetport store. 2. Adding function GetPortsOfSubnet in service mediator -- moved several functions from service to controller to support it. 3. Support to create subnetport in subnetset belongs to shared VPC or current namespace. 4. Updating vsphere-automation-sdk-go/services/nsxt to 0.9.8 to fix the relization error for subnetport. 5. Updating the real value to subnetport.Status.LogicalSwitchID.
heypnus
force-pushed
the
vpc/subnetset_port_integration
branch
from
3160a74
to
bcf0b67
Compare
dantingl
approved these changes
Aug 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
service to controller to support it.
error for subnetport.