Support codegen for v1alpha2 #288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhengxiexie
force-pushed
the
codegen_alpha2_vpc_dev
branch
2 times, most recently
from
b9f0300
to
6897a5d
Compare
dantingl
reviewed
Aug 17, 2023
dantingl
reviewed
Aug 17, 2023
zhengxiexie
force-pushed
the
codegen_alpha2_vpc_dev
branch
3 times, most recently
from
38e276d
to
f2a0d0c
Compare
wyike
reviewed
Oct 27, 2023
zhengxiexie
force-pushed
the
codegen_alpha2_vpc_dev
branch
2 times, most recently
from
08271f9
to
81c7d88
Compare
Please add more description on this PR to help reader understand why we add two versions of APIS? what's the difference? |
timdengyun
reviewed
Oct 27, 2023
zhengxiexie
force-pushed
the
codegen_alpha2_vpc_dev
branch
from
81c7d88
to
0acaa47
Compare
ok |
wyike
reviewed
Oct 30, 2023
The repo misses the v1alpha2 for codegen.
zhengxiexie
force-pushed
the
codegen_alpha2_vpc_dev
branch
from
0acaa47
to
1d51c28
Compare
|
+1, It looks good to me |
wyike
approved these changes
Oct 30, 2023
dantingl
reviewed
Oct 30, 2023
dantingl
approved these changes
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The repo misses the v1alpha2 for codegen.
IPPool v1alpha1 was implemented in NCP, nsx-operator is responsible for IPPool v1alpha2, the reason to keep the two versions in the definition of CRD is to keep the iteration history in the repository and comply with the update process k8s recommends.