-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add e2e test for Subnet #377
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
pls commit a PR for https://gitlab.eng.vmware.com/nsx-ujo/nsx-operator-ci/-/blob/main/main.py#L366 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The merge-base changed after approval.
/e2e |
/e2e |
For cluster-wide resources, `// +genclient:nonNamespaced` is required to generate CRD client. Otherwise, it will be treated as namespace scope resource.
Changes include: 1. Add CRD clientset to perform CRUD of CRDs. 2. Add SubnetSet test cases.
Create a new PR, closing this one. |
Changes include: