Re-implemented DLB cleanup in nsx-operator #408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lxiaopei
reviewed
Nov 27, 2023
lxiaopei
reviewed
Nov 27, 2023
lxiaopei
reviewed
Nov 27, 2023
zhengxiexie
force-pushed
the
clean_dlb_vpc_dev
branch
3 times, most recently
from
99abc5f
to
67721f2
Compare
dantingl
reviewed
Dec 4, 2023
TaoZou1
reviewed
Jan 29, 2024
Extract interface Comparable, and only need to implement methods in sub-resource.
Sync main branch to vpc_dev to keep both branches consistency. This is base point for future vpc_dev code rebase back to main branch.
Create the common method used by other modules. When using gomonkey to test the method, encounter the problem that the mocked method doesn't take effect, fix it by adding -gcflags=all=-l option to prohibit inline optimization.
Refactor the name convention.
Add subnet/subnetset controller to reconcile subnet/subnetset CRD. And add subnet service to perform NSX subnet CRUD operations.
Default nsx-operator reloads user/name/ca from file. Support to pass user/pass/ca from parameter
Add cleanup for ippool and subnet as securitypolicy does.
We hold these truths to be self-evident: log.info -> info, log.v(1).info -> debug, log.error-> error, log.v(2).info-> develop level log If config.Debug=true, then loglevel=1, if command is passed in loglevel and greater than debug loglevel, then the loglevel is overridden. Use another log in config.go.
1. Should delete subnet and subnetset, ListSubnetID should get them all. 2. Since ippool and staticroute rely on vpcService of serviceMediator, init vpc first, otherwise, it would report nil pointer when deleting ippool or staticroute.
zhengxiexie
force-pushed
the
clean_dlb_vpc_dev
branch
from
67721f2
to
f54149a
Compare
zhengxiexie
force-pushed
the
clean_dlb_vpc_dev
branch
5 times, most recently
from
2ee0789
to
54879db
Compare
zhengxiexie
force-pushed
the
clean_dlb_vpc_dev
branch
4 times, most recently
from
283c1b3
to
15859e5
Compare
|
/e2e |
Delete DLB resources. The size of load balancer service can be, SMALL, MEDIUM, LARGE, XLARGE, or DLB. The first four sizes are realized on Edge node as a centralized load balancer. DLB is realized on each ESXi hypervisor as a distributed load balancer. Previously, this cleanup function was implemented in NCP nsx_policy_cleanup.py. Now, it is re-implemented in nsx-operator pkg/clean/. Signed-off-by: Xie Zheng <xizheng@vmware.com>
zhengxiexie
force-pushed
the
clean_dlb_vpc_dev
branch
from
15859e5
to
24d80be
Compare
|
/e2e |
TaoZou1
approved these changes
Feb 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Delete DLB resources.
The size of load balancer service can be, SMALL, MEDIUM, LARGE, XLARGE, or DLB. The first four sizes are realized on Edge node as a centralized load balancer. DLB is realized on each ESXi hypervisor as a distributed load balancer. Previously, this cleanup function was implemented in NCP nsx_policy_cleanup.py. Now, it is re-implemented in nsx-operator pkg/clean/.