Support shared vpc #457
Merged
Support shared vpc #457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwsui
force-pushed
the
shared-vpc
branch
3 times, most recently
from
1b3f00f
to
67e2e67
Compare
|
/e2e |
|
/e2e |
1 similar comment
|
/e2e |
lxiaopei
reviewed
Dec 22, 2023
|
/e2e |
3 similar comments
|
/e2e |
|
/e2e |
|
/e2e |
|
/e2e |
3 similar comments
|
/e2e |
|
/e2e |
|
/e2e |
seanpang-vmware
previously approved these changes
Jan 2, 2024
lxiaopei
reviewed
Jan 3, 2024
lxiaopei
reviewed
Jan 3, 2024
|
/e2e |
|
/e2e |
|
/e2e |
Changes include: 1. Support subnet/subnetset creation for shared vpc. 2. Delete vpc handler and move related logic into namespace controller. 3. Refactor subnet e2e test with child test as setting up and tearing down test for subnet e2e is extremely time consuming.
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.