Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement image fetcher feature #510

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

zhengxiexie
Copy link
Contributor

@zhengxiexie zhengxiexie commented Feb 1, 2024

Sync nsx.vmware.com/node-id annotation of subnetport with nsx-t. Sync wcp.vmware.com/image-fetcher: "true" and namespace_uid label of subnetport with tags of nsx-t.

@zhengxiexie
Copy link
Contributor Author

zhengxiexie commented Feb 1, 2024

image
image
image

@heypnus
Copy link
Contributor

heypnus commented Feb 19, 2024

Please do not write the internal url in the commit message

@zhengxiexie
Copy link
Contributor Author

Please do not write the internal url in the commit message

ok

@zhengxiexie zhengxiexie force-pushed the image_fetcher branch 2 times, most recently from 323c66c to 352b46c Compare February 23, 2024 04:54
pkg/nsx/services/subnetport/builder.go Show resolved Hide resolved
pkg/util/utils.go Outdated Show resolved Hide resolved
pkg/nsx/services/subnetport/builder.go Show resolved Hide resolved
@zhengxiexie zhengxiexie force-pushed the image_fetcher branch 4 times, most recently from 1b78bb0 to b99e494 Compare March 8, 2024 07:55
@zhengxiexie
Copy link
Contributor Author

/e2e

@zhengxiexie zhengxiexie force-pushed the image_fetcher branch 2 times, most recently from 42610eb to b6edf7a Compare March 8, 2024 08:44
@timdengyun
Copy link
Contributor

/e2e

1 similar comment
@timdengyun
Copy link
Contributor

/e2e

@zhengxiexie zhengxiexie force-pushed the image_fetcher branch 2 times, most recently from 6c5f7e2 to f3b7469 Compare March 26, 2024 03:45
@zhengxiexie
Copy link
Contributor Author

/e2e

@zhengxiexie
Copy link
Contributor Author

/e2e

Sync nsx.vmware.com/node-id annotation of subnetport with nsx-t.
Sync wcp.vmware.com/image-fetcher: "true" and namespace_uid label of subnetport with tags of nsx-t.

Signed-off-by: Xie Zheng <xizheng@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants