Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement ipaddressallocation controller #626

Merged
merged 1 commit into from
Jul 22, 2024
Merged

Implement ipaddressallocation controller #626

merged 1 commit into from
Jul 22, 2024

Conversation

zhengxiexie
Copy link
Contributor

@zhengxiexie zhengxiexie commented Jul 3, 2024 •
edited
Loading

IPAddressAllocation with Private ip_address_block_visibility can be realized successfully.

apiVersion: nsx.vmware.com/v1alpha1
kind: IPAddressAllocation
metadata:
  name: guestcluster-workers-a
  namespace: zx-test
spec:
  ip_address_block_visibility: Private
  allocation_size: 32
image

IPAddressAllocation with External ip_address_block_visibility can be realized successfully

apiVersion: nsx.vmware.com/v1alpha1
kind: IPAddressAllocation
metadata:
  name: guestcluster-workers-b
  namespace: zx-test
spec:
  ip_address_block_visibility: External
  allocation_size: 32
image

The default ip_address_block_visibility for IPAddressAllocation will be Private if ip_address_block_visibility is not defined.

apiVersion: nsx.vmware.com/v1alpha1
kind: IPAddressAllocation
metadata:
  name: guestcluster-workers-b
  namespace: zx-test
spec:
  allocation_size: 32
image

Both could be deleted successfully.

If the first ipblcok is exhausted, will try next one

apiVersion: nsx.vmware.com/v1alpha1
kind: IPAddressAllocation
metadata:
  name: guestcluster-workers-c
  namespace: zx-test-2
spec:
  ip_address_block_visibility: Private
  allocation_size: 131072
image image

If all the blocks are exhausted, will return error

apiVersion: nsx.vmware.com/v1alpha1
kind: IPAddressAllocation
metadata:
  name: guestcluster-workers-d
  namespace: zx-test-2
spec:
  ip_address_block_visibility: Private
  allocation_size: 33554432
image

@zhengxiexie zhengxiexie force-pushed the zhengxie/ipallocation_controller_with_vmware branch 10 times, most recently from 3264fc7 to 3d3f212 Compare July 4, 2024 05:26
@zhengxiexie
Copy link
Contributor Author

/e2e

@zhengxiexie zhengxiexie force-pushed the zhengxie/ipallocation_controller_with_vmware branch from 3d3f212 to 53cb457 Compare July 4, 2024 09:56
@zhengxiexie
Copy link
Contributor Author

/e2e

@zhengxiexie zhengxiexie force-pushed the zhengxie/ipallocation_controller_with_vmware branch 2 times, most recently from 112ca11 to 3e3d93f Compare July 5, 2024 03:02
@zhengxiexie
Copy link
Contributor Author

/e2e

@zhengxiexie zhengxiexie force-pushed the zhengxie/ipallocation_controller_with_vmware branch 7 times, most recently from f19f8cd to 1dd2bdc Compare July 10, 2024 05:45
@zhengxiexie
Copy link
Contributor Author

/e2e

@zhengxiexie zhengxiexie force-pushed the zhengxie/ipallocation_controller_with_vmware branch 4 times, most recently from a0cb9ed to a2c8dba Compare July 15, 2024 03:58
@zhengxiexie zhengxiexie mentioned this pull request Jul 15, 2024
Merged
@zhengxiexie zhengxiexie mentioned this pull request Jul 15, 2024
Merged
heypnus
heypnus reviewed Jul 17, 2024
View reviewed changes
cmd/main.go Outdated Show resolved Hide resolved
pkg/apis/v1alpha1/ipaddressallocation_types.go Show resolved Hide resolved
pkg/controllers/ipaddressallocation/ipaddressallocation_controller.go Outdated Show resolved Hide resolved
pkg/controllers/ipaddressallocation/ipaddressallocation_controller.go Outdated Show resolved Hide resolved
pkg/controllers/ipaddressallocation/ipaddressallocation_controller.go Outdated Show resolved Hide resolved
pkg/nsx/services/ipaddressallocation/ipaddressallocation.go Outdated Show resolved Hide resolved
pkg/nsx/services/ipaddressallocation/ipaddressallocation.go Outdated Show resolved Hide resolved
pkg/nsx/services/ipaddressallocation/ipaddressallocation.go Outdated Show resolved Hide resolved
pkg/nsx/services/ipaddressallocation/ipaddressallocation.go Outdated Show resolved Hide resolved
pkg/nsx/services/ipaddressallocation/ipaddressallocation.go Show resolved Hide resolved
@zhengxiexie zhengxiexie force-pushed the zhengxie/ipallocation_controller_with_vmware branch 2 times, most recently from 3d8aaa8 to 73c4d34 Compare July 18, 2024 08:04
dantingl
dantingl reviewed Jul 19, 2024
View reviewed changes
build/yaml/crd/nsx.vmware.com_ipaddressallocations.yaml Show resolved Hide resolved
build/yaml/crd/nsx.vmware.com_nsxserviceaccounts.yaml Outdated Show resolved Hide resolved
cmd/main.go Outdated Show resolved Hide resolved
pkg/controllers/ipaddressallocation/ipaddressallocation_controller.go Outdated Show resolved Hide resolved
pkg/controllers/ipaddressallocation/ipaddressallocation_controller.go Outdated Show resolved Hide resolved
pkg/controllers/ipaddressallocation/ipaddressallocation_controller.go Outdated Show resolved Hide resolved
pkg/controllers/ipaddressallocation/ipaddressallocation_controller.go Outdated Show resolved Hide resolved
pkg/controllers/nsxserviceaccount/nsxserviceaccount_controller.go Outdated Show resolved Hide resolved
pkg/nsx/services/common/types.go Outdated Show resolved Hide resolved
pkg/nsx/services/common/types.go Show resolved Hide resolved
heypnus
heypnus reviewed Jul 19, 2024
View reviewed changes
build/yaml/crd/nsx.vmware.com_ippools.yaml Outdated Show resolved Hide resolved
cmd/main.go Outdated Show resolved Hide resolved
pkg/nsx/services/ipaddressallocation/ipaddressallocation.go Outdated Show resolved Hide resolved
pkg/nsx/services/ipaddressallocation/store.go Outdated Show resolved Hide resolved
pkg/nsx/services/ipaddressallocation/store.go Outdated Show resolved Hide resolved
@zhengxiexie zhengxiexie force-pushed the zhengxie/ipallocation_controller_with_vmware branch from 73c4d34 to 7e299a7 Compare July 19, 2024 09:00
@zhengxiexie
Implement ipaddressallocation controller
c46325e 
Signed-off-by: Xie Zheng <xizheng@vmware.com>
@zhengxiexie zhengxiexie force-pushed the zhengxie/ipallocation_controller_with_vmware branch from 7e299a7 to c46325e Compare July 19, 2024 09:03
@zhengxiexie
Copy link
Contributor Author

/e2e

1 similar comment
@zhengxiexie
Copy link
Contributor Author

/e2e

@zhengxiexie zhengxiexie merged commit e694368 into vmware-tanzu:main Jul 22, 2024
2 checks passed
@zhengxiexie zhengxiexie mentioned this pull request Aug 15, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dantingl dantingl dantingl approved these changes

@heypnus heypnus heypnus approved these changes

Assignees
No one assigned
Labels
cla-not-required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zhengxiexie @dantingl @heypnus @vmwclabot