-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Specify node-type during creating ClusterControlPlane #628
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Wenqi Qiu <wenqiq@vmware.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A small comment on the variable name.
I think maybe you can invite Bin and Ran to review this patch, too.
Signed-off-by: Wenqi Qiu <wenqiq@vmware.com>
github.com/vmware/vsphere-automation-sdk-go/services/nsxt => github.com/zhengxiexie/vsphere-automation-sdk-go/services/nsxt v0.12.3-0.20240628090521-3ad1af047210 | ||
github.com/vmware/vsphere-automation-sdk-go/services/nsxt-mp => github.com/zhengxiexie/vsphere-automation-sdk-go/services/nsxt-mp v0.6.3-0.20240628090521-3ad1af047210 | ||
github.com/vmware/vsphere-automation-sdk-go/lib => github.com/wenqiq/vsphere-automation-sdk-go/lib v0.7.3-0.20240711034503-a008ff3b1f16 | ||
github.com/vmware/vsphere-automation-sdk-go/runtime => github.com/wenqiq/vsphere-automation-sdk-go/runtime v0.7.3-0.20240711034503-a008ff3b1f16 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what change does thei repo include? main branch is using xie's repo, did you fork from xie's repo?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It introduce a new field node_type in cluster-control-plane create request body. Now the change is merged to NSX 9.0.0, but I'm not sure if this change is available in the github.com/vmware/vsphere-automation-sdk-go , because the NSX 9.0.0 release is not GAed yet. So we need this new field in the sdk before NSX GA.
No description provided.