Get path info from store while deleting staticroute #632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/e2e |
timdengyun
previously approved these changes
Jul 10, 2024
|
/e2e |
|
/e2e |
timdengyun
reviewed
Jul 11, 2024
TaoZou1
force-pushed
the
readvpcinfo
branch
2 times, most recently
from
cd711e0
to
1defa17
Compare
In previous version, controller tried to get org/project/vpc info from vpc service. But vpc service may delete vpc before staticroute. Read org/project/vpc from staticroute path
timdengyun
reviewed
Jul 11, 2024
timdengyun
approved these changes
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In previous version, controller tried to get org/project/vpc info from vpc service. But vpc service may delete vpc before staticroute.
Read org/project/vpc from staticroute path