Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass context.Context directly rather than passing its pointer in function parameters #714

Merged
merged 1 commit into from
Aug 23, 2024
Merged

Pass context.Context directly rather than passing its pointer in function parameters #714

merged 1 commit into from
Aug 23, 2024

Conversation

wenqiq
Copy link
Contributor

@wenqiq wenqiq commented Aug 21, 2024 •
edited
Loading

@wenqiq wenqiq mentioned this pull request Aug 21, 2024
Merged
zhengxiexie
zhengxiexie approved these changes Aug 22, 2024
View reviewed changes
Copy link
Contributor

@zhengxiexie zhengxiexie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wenqiq
Pass context.Context directly rather than passing its pointer in func…
b2f56de 
…tion parameters

Signed-off-by: Wenqi Qiu <wenqiq@vmware.com>
timdengyun
timdengyun approved these changes Aug 22, 2024
View reviewed changes
Copy link
Contributor

@timdengyun timdengyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wenqiq wenqiq merged commit 7331b75 into vmware-tanzu:main Aug 23, 2024
2 checks passed
@wenqiq wenqiq deleted the topic/wenqi/code-improve branch August 27, 2024 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhengxiexie zhengxiexie zhengxiexie approved these changes

@timdengyun timdengyun timdengyun approved these changes

Assignees
No one assigned
Labels
cla-not-required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wenqiq @zhengxiexie @timdengyun @vmwclabot