Add conventions #23
Merged
Add conventions #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scothis
force-pushed
the
add-conventions
branch
2 times, most recently
from
299e9d4 to
ef7b81d
Compare
|
CI isn't configured to run for PRs, but you can see the push run from my fork https://github.com/scothis/package-for-cartographer/runs/5740260605?check_suite_focus=true |
cirocosta
reviewed
Mar 30, 2022
cirocosta
reviewed
Mar 30, 2022
This was referenced Mar 30, 2022
Open
scothis
force-pushed
the
add-conventions
branch
2 times, most recently
from
d835261 to
13461e5
Compare
cirocosta
pushed a commit
to vmware-tanzu/cartographer
that referenced
this pull request
Apr 6, 2022
in order to make the installation of Cartographer in carvel-based packaging easier, we used to have this secret that gets filled by secretgen-controller as part of the set of objects shipped in the release, but given that it's such a packaging-specific detail, here we get rid of it favoring `package-for-cartographer` as the location for doing so. see vmware-tanzu/package-for-cartographer#23 for the PR where that addition of a secret to the package takes place (file: src/cartographer/config/overlays/image-pull-secret.yaml) Signed-off-by: Ciro S. Costa <ciroscosta@vmware.com>
4 tasks
cirocosta
approved these changes
Apr 6, 2022
There was a problem hiding this comment.
lgtm! to carto, just submitted pr for removing placeholder secret
Cartographer Conventions is a new component that is part of Cartographer. Adding the latest release of the conventions to the exiting cartographer package. The version numbers for each component are distinct and intended to drift. All resources are installed into the cartographer-system namespace. There are two user facing values: - `ca_cert_data` allows users to trust additional ca certificates, which are commonly used inside corporate networks for internal image registries. - `excluded_components` a list of components that should not be installed. The only valid values at the moment are `conventions` and `cartographer. There are a handful of places where cartographer and cartographer conventions have different behavior that we can iron out over time. They include: - image pull secrets - conventions defines the secret and injects the pull secret reference inside the bundle. - aggregated roles - cartographer conventions can drop their inline roles now that the aggregated values are defined in package. Signed-off-by: Scott Andrews <andrewssc@vmware.com>
cirocosta
pushed a commit
to vmware-tanzu/cartographer
that referenced
this pull request
Apr 7, 2022
- config: remove placeholder secret in order to make the installation of Cartographer in carvel-based packaging easier, we used to have this secret that gets filled by secretgen-controller as part of the set of objects shipped in the release, but given that it's such a packaging-specific detail, here we get rid of it favoring `package-for-cartographer` as the location for doing so. see vmware-tanzu/package-for-cartographer#23 for the PR where that addition of a secret to the package takes place (file: src/cartographer/config/overlays/image-pull-secret.yaml) - docs: remove placeholder secret when installing cartographer, such object is not included anymore, so it wouldn't show up in the list of objects that kapp is managing - packaging: remove everything packaging related any carvel packaging related to cartographer now takes place under `vmware-tanzu/package-for-cartographer`, so, get rid of this leftover. - hack: remove registry authentication we used to bring up the registry with authentication enabled so that we could be sure that the packaging work was right w/ regards to providing credentials via secretgen's placeholder secrets, but now that such responsability has shifted towards the packaging efforts under `vmware-tanzu/package-for-cartographer`, we can now get rid of this requirement from this repository - hack: remove registry creds from examples setup with the registry used by those not requiring any more auth, we can get rid of those credentials from the setup. - hack: remove references to registry-auth with the removal of the need for authenticating against the registry where we publish the release of cartographer, we can now skip all the references to the previously `hack/registry-auth` directory where a secretexport was placed for the credentials to the local registry Signed-off-by: Ciro S. Costa <ciroscosta@vmware.com>
cirocosta
approved these changes
Apr 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cartographer Conventions is a new component that is part of
Cartographer. Adding the latest release of the conventions to the
exiting cartographer package. The version numbers for each component are
distinct and intended to drift. All resources are installed into the
cartographer-system namespace.
There are two user facing values:
ca_cert_dataallows users to trust additional ca certificates, whichare commonly used inside corporate networks for internal image
registries.
excluded_componentsa list of components that should not beinstalled. The only valid values at the moment are
conventionsand`cartographer.
There are a handful of places where cartographer and cartographer
conventions have different behavior that we can iron out over time. They
include:
pull secret reference inside the bundle.
roles now that the aggregated values are defined in package.
Signed-off-by: Scott Andrews andrewssc@vmware.com